Embed: Remove aspect ratio classes when transforming into Paragraph #68721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
tellthemachines,
ajitbohra and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b474d6f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12810325521
|
t-hamano
approved these changes
Jan 18, 2025
There was a problem hiding this comment.
LGTM!
- Open a post or page.
- Embed a YouTube link.
- Transform into Paragraph.
- Confirm no additional classes are displayed in the Advanced panel.
- Embed a YouTube link.
- Add a custom test class.
- Transform into Paragraph.
- Confirm that only the custom test class was retained.
I have confirmed that the above works correctly.
|
Thanks, @t-hamano! |
Gulamdastgir-Momin
pushed a commit
to Gulamdastgir-Momin/gutenberg
that referenced
this pull request
Jan 23, 2025
…ordPress#68721) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ZebulanStanphill <[email protected]> Co-authored-by: kathrynwp <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: petitphp <[email protected]> Co-authored-by: ts-mz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #39616
Alternative to #44947 and #60895.
Updates embed block transformation to remove aspect ratio classes while retaining any additional classes added by the user. The aspect ratio classes are specific to embed blocks and shouldn't be kept during transformations.
Adjust the custom classes transformation hook to add classes only from the source when the transformation doesn't provide them. Avoids attribute overrides when the transformed block already provides class names.
Testing Instructions
Testing Instructions for Keyboard
Same.